Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sort icons #17984

Merged
merged 6 commits into from Apr 10, 2023
Merged

Fix sort icons #17984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5fd35ac
Fix sort icons
Nitwel Mar 29, 2023
a54b1ba
Run linter
paescuj Mar 29, 2023
4062916
Merge branch 'main' into fix-17974
br41nslug Apr 3, 2023
86120b0
Fix return value for unsorted headers
paescuj Apr 7, 2023
94ddc17
Merge branch 'main' into fix-17974
paescuj Apr 7, 2023
8e2cfb1
Merge branch 'main' into fix-17974
rijkvanzanten Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/src/components/v-table/table-header.vue
View file
Open in desktop
Expand Up @@ -180,7 +180,8 @@ function getClassesForHeader(header: Header) {
}

function getTooltipForSortIcon(header: Header) {
return props.sort.by === header.value && props.sort.desc === false ? 'sort_desc' : 'sort_asc';
if (props.sort.by === null || props.sort.by !== header.value) return 'sort_asc';
return props.sort.desc === false ? 'sort_desc' : 'disable_sort';
}

function changeSort(header: Header) {
Expand Down Expand Up @@ -327,6 +328,7 @@ function toggleManualSort() {
color: var(--foreground-subdued);
opacity: 0;
transition: opacity var(--fast) var(--transition);
transform: scaleY(-1);
}

&:hover .action-icon {
Expand Down
1 change: 1 addition & 0 deletions app/src/lang/translations/en-US.yaml
View file
Open in desktop
Expand Up @@ -1458,6 +1458,7 @@ export_started: Export Started
export_started_copy: Your export has started. You'll be notified when it's ready to download.
sort_asc: Sort Ascending
sort_desc: Sort Descending
disable_sort: Disable Sorting
template: Template
require_value_to_be_set: Require value to be set on creation
translation: Translation
Expand Down