Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sort icons #17984

Merged
merged 6 commits into from Apr 10, 2023
Merged

Fix sort icons #17984

merged 6 commits into from Apr 10, 2023

Conversation

Nitwel
Copy link
Member

@Nitwel Nitwel commented Mar 29, 2023

Fixes #17974

@Nitwel Nitwel requested a review from a team March 29, 2023 08:30
@Nitwel Nitwel self-assigned this Mar 29, 2023
@Nitwel Nitwel requested review from freekrai, br41nslug and ConnorSimply and removed request for a team March 29, 2023 08:30
@paescuj paescuj requested review from paescuj and removed request for freekrai April 7, 2023 09:19
@paescuj paescuj requested review from a team and removed request for a team April 7, 2023 09:34
br41nslug
br41nslug approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@br41nslug br41nslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

firefox_jpgxQZD7VU.mp4

@br41nslug br41nslug merged commit 8ea94c3 into main Apr 10, 2023
5 checks passed
@br41nslug br41nslug deleted the fix-17974 branch April 10, 2023 12:27
@rijkvanzanten rijkvanzanten added this to the Next Release milestone Apr 13, 2023
hanneskuettner pushed a commit to hanneskuettner/directus that referenced this pull request Apr 18, 2023
@Nitwel @paescuj
@br41nslug @rijkvanzanten @hanneskuettner
Fix sort icons (directus#17984)
3c4b18e 
* Fix sort icons

* Run linter

* Fix return value for unsorted headers

---------

Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
meditadvisors pushed a commit to ciso360ai/directus-mod that referenced this pull request May 13, 2023
@Nitwel @paescuj
@br41nslug @rijkvanzanten @faustro
Fix sort icons (directus#17984)
2f20c9c 
* Fix sort icons

* Run linter

* Fix return value for unsorted headers

---------

Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paescuj paescuj paescuj approved these changes

@br41nslug br41nslug br41nslug approved these changes

@ConnorSimply ConnorSimply

Assignees

@Nitwel Nitwel

Labels
Bug Package: @directus/app
Projects
None yet
Milestone
v9.25.0
Development

Successfully merging this pull request may close these issues.

Incorrect icon and label for sort removal in m2m table layout
4 participants
@Nitwel @paescuj @br41nslug @rijkvanzanten