Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only hide v-select options #17953

Merged
merged 1 commit into from Mar 27, 2023
Merged

Only hide v-select options #17953

merged 1 commit into from Mar 27, 2023

Conversation

Nitwel
Copy link
Member

@Nitwel Nitwel commented Mar 27, 2023

Description

Before, we would filter all non matching options out of the possible select options, meaning when we alread had something selected that couldn't be matched anymore, we would show only the value. By hiding the options instead of filtering them, we prevent this issue.

Fixes #17931

@Nitwel Nitwel requested a review from a team March 27, 2023 10:34
@Nitwel Nitwel self-assigned this Mar 27, 2023
@Nitwel Nitwel requested review from paescuj, br41nslug and ConnorSimply and removed request for a team March 27, 2023 10:34
Copy link
Member

@br41nslug br41nslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rijkvanzanten rijkvanzanten merged commit 75ad487 into main Mar 27, 2023
4 checks passed
@rijkvanzanten rijkvanzanten deleted the fix-17931 branch March 27, 2023 14:12
Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rijkvanzanten rijkvanzanten added this to the Next Release milestone Apr 4, 2023
meditadvisors pushed a commit to ciso360ai/directus-mod that referenced this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v-select minor bug
4 participants