Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix archive field reactivity for new collection #17862

Merged
merged 1 commit into from Mar 21, 2023

Conversation

azrikahar
Copy link
Member

@azrikahar azrikahar commented Mar 21, 2023

Description

Currently archiveField is hardcoded to 'status', even after we edit the status field name before saving the new collection:

This causes the archive field to be saved incorrectly even when we changed the default 'status' name to something else:

chrome_oC04oATSg9.mp4

The TypeError: Cannot read properties of undefined (reading 'type') error itself is being addressed in #17802, so this PR only ensures the archive field name is actually depending on the status field name, similar to the solution used for sort field:

sortField.value = systemFields.sort.name;

Fixes ENG-833

Result

chrome_LEr6RiBcoe.mp4

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

@azrikahar
Copy link
Member Author

/linear

@github-actions
Copy link

🤖 Linear issue created! Maintainers can access it here: ENG-833

@azrikahar azrikahar requested review from a team, freekrai, ConnorSimply and Nitwel and removed request for a team March 21, 2023 09:32
Copy link
Member

@ConnorSimply ConnorSimply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works fine!

@azrikahar azrikahar added this to the Next Release milestone Mar 21, 2023
@azrikahar azrikahar merged commit 46c1666 into main Mar 21, 2023
4 checks passed
@azrikahar azrikahar deleted the azri/fix-archive-field-name branch March 21, 2023 22:57
meditadvisors pushed a commit to ciso360ai/directus-mod that referenced this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants