Fix AllowList checking only when defined #17830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitwel
requested review from
paescuj,
br41nslug and
azrikahar
and removed request for
a team
br41nslug
approved these changes
Mar 17, 2023
meditadvisors
pushed a commit
to ciso360ai/directus-mod
that referenced
this pull request
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The problem was that we were checking for😄 )
!props.typeAllowList.includes(field.type)which evaluates to true ifprops.typeAllowListis undefined, instead, it should evaluate to false.This is a regression from #17186. (nice number coincidence
Fixes #17681