Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AllowList checking only when defined #17830

Merged
merged 1 commit into from Mar 17, 2023
Merged

Fix AllowList checking only when defined #17830

merged 1 commit into from Mar 17, 2023

Conversation

Nitwel
Copy link
Member

@Nitwel Nitwel commented Mar 17, 2023

The problem was that we were checking for !props.typeAllowList.includes(field.type) which evaluates to true if props.typeAllowList is undefined, instead, it should evaluate to false.
This is a regression from #17186. (nice number coincidence 馃槃 )

Fixes #17681

@Nitwel Nitwel requested a review from a team March 17, 2023 14:23
@Nitwel Nitwel self-assigned this Mar 17, 2023
@Nitwel Nitwel requested review from paescuj, br41nslug and azrikahar and removed request for a team March 17, 2023 14:23
Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 馃槃

@br41nslug br41nslug merged commit 91c2d8b into main Mar 17, 2023
4 checks passed
@br41nslug br41nslug deleted the fix-17681 branch March 17, 2023 17:48
@licitdev licitdev added this to the Next Release milestone Mar 17, 2023
meditadvisors pushed a commit to ciso360ai/directus-mod that referenced this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in Application O2M relation foreign keys grayed out
4 participants