New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keep folder on reupload #17744
Merged
Fix keep folder on reupload #17744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
paescuj
approved these changes
Mar 15, 2023
jaads
requested changes
Mar 16, 2023
jaads
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works as expected
meditadvisors
pushed a commit
to ciso360ai/directus-mod
that referenced
this pull request
May 13, 2023
* Fix deleting data on reupload * only update folder when necessary * run linter * fix replacing filename_download and title * run linter * fix if statement * clean up code * Remove unused import of 'File' * cleanup code --------- Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The problem was that the api would override the folder field, because it didn't existed in the payload but the case that the item already exists and has a folder wasn't considered.
Fixes #17427 Fixes: ENG-659