Fix default values #15710
Merged
Fix default values #15710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paescuj
requested review from
a team,
paescuj,
licitdev and
azrikahar
and removed request for
a team
azrikahar
reviewed
Mar 10, 2023
azrikahar
reviewed
Mar 21, 2023
azrikahar
approved these changes
Mar 21, 2023
rijkvanzanten
approved these changes
Apr 10, 2023
paescuj
added a commit
that referenced
this pull request
Apr 11, 2023
* Fix default values * run linter * use assign * fix working with permissions * run linter * fix set related item to empty when having junction * check for empty * Update app/src/views/private/components/drawer-item.vue --------- Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com> Co-authored-by: Brainslug <br41nslug@users.noreply.github.com> Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch> Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
hanneskuettner
pushed a commit
to hanneskuettner/directus
that referenced
this pull request
Apr 18, 2023
* Fix default values * run linter * use assign * fix working with permissions * run linter * fix set related item to empty when having junction * check for empty * Update app/src/views/private/components/drawer-item.vue --------- Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com> Co-authored-by: Brainslug <br41nslug@users.noreply.github.com> Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch> Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
meditadvisors
pushed a commit
to ciso360ai/directus-mod
that referenced
this pull request
May 13, 2023
* Fix default values * run linter * use assign * fix working with permissions * run linter * fix set related item to empty when having junction * check for empty * Update app/src/views/private/components/drawer-item.vue --------- Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com> Co-authored-by: Brainslug <br41nslug@users.noreply.github.com> Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch> Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
There where 2 Problems.
if(schema.default_value)which would fail when you want to set the default value to false.Fixes #15569, fixes ENG-189